Skip to content

refactor: establish Animation folder feature - #323

Open
jderochervlk wants to merge 1 commit into
codex/option5-messaging-folderfrom
codex/option5-animation-folder
Open

refactor: establish Animation folder feature#323
jderochervlk wants to merge 1 commit into
codex/option5-messaging-folderfrom
codex/option5-animation-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 13 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #322.

Summary

  • add the target src/animation folder on the unqualified internal Animation feature
  • move Animation, AnimationEffect, and DocumentTimeline out of the legacy broad DOM folder
  • add the supported WebAPI.Animation feature with its WebAPI.Event dependency
  • preserve all three flat public module paths and binding signatures

Temporary state

  • this PR introduces no compatibility aliases, file exclusions, or module slices; the Animation folder membership and public implication are final
  • DOMNodes interfaces currently call Animation APIs directly; that dependency will be resolved explicitly when the DOMNodes boundary is implemented rather than hidden in this layer

Review focus

  • the WebAPI.Animation -> WebAPI.Event + Animation implication
  • complete Animation folder membership
  • unchanged public APIs

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,Animation
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70d2716e89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch 2 times, most recently from 8cf0ff7 to 6c99e61 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch 2 times, most recently from 7aa780f to a3f61c6 Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from a3f61c6 to e8efc82 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch 2 times, most recently from 54ac867 to fb40365 Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from fb40365 to e459112 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from e459112 to 34fc8b2 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from 34fc8b2 to 04911b6 Compare August 5, 2026 15:09
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from 04911b6 to 3686403 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-animation-folder branch from 3686403 to a86db72 Compare August 5, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant