refactor: establish Animation folder feature - #323
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70d2716e89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
2 times, most recently
from
August 5, 2026 12:14
8cf0ff7 to
6c99e61
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
2 times, most recently
from
August 5, 2026 12:34
7aa780f to
a3f61c6
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 13:40
a3f61c6 to
e8efc82
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
2 times, most recently
from
August 5, 2026 14:00
54ac867 to
fb40365
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 14:30
fb40365 to
e459112
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 14:50
e459112 to
34fc8b2
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 15:09
34fc8b2 to
04911b6
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 15:45
04911b6 to
3686403
Compare
jderochervlk
force-pushed
the
codex/option5-animation-folder
branch
from
August 5, 2026 17:39
3686403 to
a86db72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 13 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #322.
Summary
src/animationfolder on the unqualified internalAnimationfeatureAnimation,AnimationEffect, andDocumentTimelineout of the legacy broad DOM folderWebAPI.Animationfeature with itsWebAPI.EventdependencyTemporary state
Review focus
WebAPI.Animation -> WebAPI.Event + AnimationimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,Animationnpm run buildnpm testnpm run format:checkgit diff --check